svn commit: r338348 - in head/sys/dev: drm drm2

[Warner Losh]

Your comments weren't exactly clear in the review (even after
clarification), and they were at odds with what I'd been told, I thought,
the graphics folks wanted to message: all 64-bit platforms use
drm-stable/drm-devel.

Warner

On Tue, Aug 28, 2018 at 11:51 AM Kevin Bowling <kevin.bowling at kev009.com>
wrote:

> Legacy would be needed by existing these existing ppc64 at the moment
> and I pointed out in the review that LP64 is not the correct heuristic
> but was dismissed without understanding the point.
>
> On Tue, Aug 28, 2018 at 10:36 AM, Mark Millard via svn-src-head
> <svn-src-head at freebsd.org> wrote:
> > For the below I wonder if graphics/drm-stable-kmod
> > would be correct for old powerpc64 PowerMac's and
> > such.
> >
> > Presuming graphics/drm-legacy-kmod (I do not know):
> > Tier 2, old equipment, etc. so it may just be an item
> > for handling questions on the lists rather than making
> > a mess instead of the below to cover sufficient
> > alternatives.
> >
> >> Modified: head/sys/dev/drm2/drm_os_freebsd.h
> >>
> ==============================================================================
> >> --- head/sys/dev/drm2/drm_os_freebsd.h        Tue Aug 28 14:46:49 2018
>       (r338347)
> >> +++ head/sys/dev/drm2/drm_os_freebsd.h        Tue Aug 28 14:46:55 2018
>       (r338348)
> >> @@ -154,6 +154,20 @@ typedef void                     irqreturn_t;
> >>       *(volatile u_int64_t *)(((vm_offset_t)(map)->handle) +          \
> >>           (vm_offset_t)(offset)) = htole64(val)
> >>
> >> +#ifdef __LP64__
> >> +#define DRM_PORT "graphics/drm-stable-kmod"
> >> +#else
> >> +#define DRM_PORT "graphics/drm-legacy-kmod"
> >> +#endif
> >> +
> >> +#define DRM_OBSOLETE(dev)
>       \
> >> +    do {
>        \
> >> +     device_printf(dev,
> "=======================================================\n"); \
> >> +     device_printf(dev, "This code is obsolete abandonware. Install
> the " DRM_PORT " pkg\n"); \
> >> +     device_printf(dev,
> "=======================================================\n"); \
> >> +     gone_in_dev(dev, 13, "drm2 drivers");
>        \
> >> +    } while (0)
> >> +
> >>  /* DRM_READMEMORYBARRIER() prevents reordering of reads.
> >>   * DRM_WRITEMEMORYBARRIER() prevents reordering of writes.
> >>   * DRM_MEMORYBARRIER() prevents reordering of reads and writes.
> >
> >
> > ===
> > Mark Millard
> > marklmi at yahoo.com
> > ( dsl-only.net went
> > away in early 2018-Mar)
> >
> > _______________________________________________
> > svn-src-head at freebsd.org mailing list
> > https://lists.freebsd.org/mailman/listinfo/svn-src-head
> > To unsubscribe, send any mail to "svn-src-head-unsubscribe at freebsd.org"
>