svn commit: r337956 - in head: . bin/ls
Rodney W. Grimes
freebsd at pdx.rh.CN85.dnsmgr.net
Fri Aug 17 15:48:09 UTC 2018
> On Fri, Aug 17, 2018 at 10:24 AM, Rodney W. Grimes
> <freebsd at pdx.rh.cn85.dnsmgr.net> wrote:
> > [ Charset UTF-8 unsupported, converting... ]
> >> Author: kevans
> >> Date: Fri Aug 17 04:15:51 2018
> >> New Revision: 337956
> >> URL: https://svnweb.freebsd.org/changeset/base/337956
> >>
> >> Log:
> >> ls(1): Add --color=when
> >>
> >> --color may be set to one of: 'auto', 'always', and 'never'.
> >>
> >> 'auto' is the default behavior- output colors only if -G or COLORTERM are
> >
> > Why different than coreutils ls? Default for coreutils is none.
>
> I guess this was worded poorly and you skipped both the review and
> reading the diff... this is still contingent on environment variables
> or -G being specified.
The review lasted for less time than I had to respond,
it was also evolving with changes from 0mp and cem. I
can not typically respond to any review in less than 24
hours, and usually need more like 48.
>
> >> set, and only if stdout is a tty.
> >>
> >> 'always' is a new behavior- output colors always. termcap(5) will be
> >> consulted unless TERM is unset or not a recognized terminal, in which case
> >> ls(1) will fall back to explicitly outputting ANSI escape sequences.
> >>
> >> 'never' to turn off any environment variable and -G usage.
> > Why different than core utils? Coreutils uses none.
>
> I guess this was worded poorly and you skipped both the review and
> reading the diff... this is still contingent on environment variables
> or -G being specified.
Is the word never or none? It looks prettyh clear to me in the diff:
else if (strcmp(optarg, "never") == 0)
414 colorflag = COLORFLAG_NEVER;
415 else
Let me repeat, coreutils ls uses color==none not color==never,
the default in coreutils ls is color==none this is NOT depedent
on any environment variables.
Can we please bring our ls into conformance with:
https://www.gnu.org/software/coreutils/manual/html_node/General-output-formatting.html
in respect to how --color works?
IMHO, doing anything different is a huge POLA issue.
> Thanks,
> Kyle Evans
Thanks,
--
Rod Grimes rgrimes at freebsd.org
More information about the svn-src-head
mailing list