svn commit: r337736 - in head/sys: netinet netinet6

[Alan Somers]

On Fri, Aug 17, 2018 at 7:31 AM, Andrey V. Elsukov <bu7cher at yandex.ru>
wrote:

> On 16.08.2018 21:34, Alan Somers wrote:
> > On Tue, Aug 14, 2018 at 1:54 AM, Andrey V. Elsukov <ae at freebsd.org
> > <mailto:ae at freebsd.org>> wrote:
> >
> >     Author: ae
> >     Date: Tue Aug 14 07:54:14 2018
> >     New Revision: 337736
> >     URL: https://svnweb.freebsd.org/changeset/base/337736
> >     <https://svnweb.freebsd.org/changeset/base/337736>
> >
> >     Log:
> >       Restore ability to send ICMP and ICMPv6 redirects.
> >
> >       It was lost when tryforward appeared. Now ip[6]_tryforward will be
> >     enabled
> >       only when sending redirects for corresponding IP version is
> >     disabled via
> >       sysctl. Otherwise will be used default forwarding function.
> >
> >       PR:           221137
> >
> > This change broke the sys/netipsec/tunnel tests.  I don't know if it's a
> > limitation of the tests, or a genuine kernel bug, but I bisected the
> > regression down to this change.  Can you please fix it?
> >
> > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/8630/
> testReport/sys.netipsec.tunnel/empty/v4/
>
> I think it is because IPv4 tests use broadcast addresses in some places.
> The attached patch fixes the test for me.
>
> --
> WBR, Andrey V. Elsukov
>

Hm, it certainly is weird to use broadcast addresses in this context.  But
why did that work before your commit and not after?