svn commit: r337791 - in head: crypto/openssl crypto/openssl/apps crypto/openssl/crypto crypto/openssl/crypto/asn1 crypto/openssl/crypto/bio crypto/openssl/crypto/bn crypto/openssl/crypto/bn/asm cr...

[Ian Lepore]

On Thu, 2018-08-16 at 12:10 -0700, Bryan Drewery wrote:
> On 8/16/18 11:47 AM, Larry Rosenman wrote:
> > 
> > On Thu, Aug 16, 2018 at 11:34:59AM -0700, Bryan Drewery wrote:
> > > 
> > > On 8/16/18 11:21 AM, Larry Rosenman wrote:
> > > > 
> > > > On Thu, Aug 16, 2018 at 02:02:52PM -0400, Jung-uk Kim wrote:
> > > > > 
> > > > > On 18. 8. 16., Larry Rosenman wrote:
> > > > > > 
> > > > > > On Thu, Aug 16, 2018 at 01:48:40PM -0400, Jung-uk Kim
> > > > > > wrote:
> > > > > > > 
> > > > > > > On 18. 8. 16., Ravi Pokala wrote:
> > > > > > > > 
> > > > > > > > -----Original Message-----
> > > > > > > > From: <owner-src-committers at freebsd.org> on behalf of
> > > > > > > > Jung-uk Kim <jkim at FreeBSD.org>
> > > > > > > > Date: 2018-08-14, Tuesday at 10:48
> > > > > > > > To: <src-committers at freebsd.org>, <svn-src-all at freebsd.
> > > > > > > > org>, <svn-src-head at freebsd.org>
> > > > > > > > Subject: svn commit: r337791 - in head: crypto/openssl
> > > > > > > > crypto/openssl/apps crypto/openssl/crypto
> > > > > > > > crypto/openssl/crypto/asn1 crypto/openssl/crypto/bio
> > > > > > > > crypto/openssl/crypto/bn crypto/openssl/crypto/bn/asm
> > > > > > > > cr...
> > > > > > > > 
> > > > > > > > > 
> > > > > > > > > Author: jkim
> > > > > > > > > Date: Tue Aug 14 17:48:02 2018
> > > > > > > > > New Revision: 337791
> > > > > > > > > URL: https://svnweb.freebsd.org/changeset/base/337791
> > > > > > > > > 
> > > > > > > > > Log:
> > > > > > > > >   Merge OpenSSL 1.0.2p.
> > > > > > > > Is it just me, or did this change break all the worlds?
> > > > > > > > 
> > > > > > > > I got errors like this:
> > > > > > > > 
> > > > > > > > -----------------------------------------------------
> > > > > > > > -----------
> > > > > > > > /usr/bin/ld: error: undefined symbol: main
> > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > referenced by crt1.c:74
> > > > > > > > > > > (/usr/home/rpokala/freebsd/clean/base/head/lib/cs
> > > > > > > > > > > u/amd64/crt1.c:74)
> > > > > > > > > > >               /build/usr/home/rpokala/freebsd/cle
> > > > > > > > > > > an/base/head/amd64.amd64/tmp/usr/lib/crt1.o:(_sta
> > > > > > > > > > > rt)
> > > > > > > > /usr/bin/ld: error: undefined symbol: Fssh_error
> > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > referenced by moduli.c:257
> > > > > > > > > > > (/usr/home/rpokala/freebsd/clean/base/head/crypto
> > > > > > > > > > > /openssh/moduli.c:257)
> > > > > > > > > > >               /tmp/moduli-
> > > > > > > > > > > 6780ab.o:(Fssh_gen_candidates)
> > > > > > > > -----------------------------------------------------
> > > > > > > > -----------
> > > > > > > > 
> > > > > > > > At first I thought it was because I was rebuilding
> > > > > > > > without cleaning, but I nuked the tree and rebuilt from
> > > > > > > > scratch, and got the same error.
> > > > > > > > 
> > > > > > > > I didn't bisect it to this change, but it's the only
> > > > > > > > recent change to crypto...
> > > > > > > I built worlds many times and I haven't seen such
> > > > > > > problem.  In fact,
> > > > > > > Jenkins didn't break on amd64 after the commit.
> > > > > > > 
> > > > > > > https://ci.freebsd.org/job/FreeBSD-head-amd64-build/9888/
> > > > > > Do you or jenkins run with meta-mode?  That seems to be a
> > > > > > necessary
> > > > > > condition for the failure.
> > > > > I don't do meta-mode.  I don't know much about Jenkins build
> > > > > but I don't
> > > > > think it does.  Is it a requirement now?
> > > > > 
> > > Jenkins doesn't use META_MODE and it's not a requirement.
> > Can you (bdrewery@) possibly diagnose why meta-mode is messing this
> > up
> > with the moduli file?
> > 
> > > 
> > > 
> Sure. I'm hitting it as well.
> 
> 

There's a thread about it in -current@ too.

-- Ian