svn commit: r337554 - in head/sys/cam: . ata nvme scsi

[Warner Losh]

On Thu, Aug 9, 2018 at 3:56 PM, Scott Long <scottl at samsco.org> wrote:

>
>
> > On Aug 9, 2018, at 3:53 PM, Conrad Meyer <cem at FreeBSD.org> wrote:
> >
> > Author: cem
> > Date: Thu Aug  9 21:53:32 2018
> > New Revision: 337554
> > URL: https://svnweb.freebsd.org/changeset/base/337554
> >
> > Log:
> >  cam(4): Add an xpt-neutral flag indicating a valid panic CCB
> >
> >  No functional change.
> >
> >  Note that this change is careful to set the CCB header xflags after
> >  foo_fill_bar() routines, which generally zero existing flags.  An
> earlier
> >  version of this patch mistakenly set the flag before the fill routines.
> >
> >  Submitted by:        Scott Ferris <sferris AT isilon.com>, jhibbits@
> >  Reviewed by: bdrewery@, markj@, and non-committer FreeBSD contributor
> Anton Rang
> >  Sponsored by:        Dell EMC Isilon
>
> What’s the purpose of this flag?  I see it gets set in plenty of places,
> but never checked.
>

It kinda looks like something I recall removing when I did the runccb fixes
so they worked when we were dumping. We used to need this, but we don't
anymore. I have the same question: Why?

Maybe these CAM changes should go through phabricator?

Warner