svn commit: r336905 - head/tests/sys/kqueue/libkqueue
David A. Bright
david at bright-family.net
Fri Aug 3 19:40:28 UTC 2018
On 07/30/2018 09:21 AM, David Bright wrote:
> Author: dab
> Date: Mon Jul 30 14:21:49 2018
> New Revision: 336905
> URL: https://svnweb.freebsd.org/changeset/base/336905
>
> Log:
> Correct possible misleading error message in kqtest.
>
> ian@ pointed out that in the test_abstime() function time(NULL) is
> used twice; once in an "if" test and again in the enclosed error
> message. If the true branch was taken and the process got preempted
> before the second time(NULL) call, by the time the error message was
> generated enough time could have elapsed that the message could claim
> that the event came "too early" but print an event time that was after
> the expected timeout. Correct by making the time(NULL) call only once
> and using that returned time in both the "if" test and the error
> message.
>
> Reported by: ian@
> MFC after: 4 days
> X-MFC-with: r336761, r336781, r336802
It turns out that this won't be MFC'd as the change doesn't apply to
stable/11 or stable/10. The particular test corrected by this change
doesn't exist in those branches.
--
David Bright
dab at FreeBSD.org
More information about the svn-src-head
mailing list