svn commit: r332783 - head/sys/dev/nvme

Warner Losh imp at FreeBSD.org
Thu Apr 19 16:05:49 UTC 2018


Author: imp
Date: Thu Apr 19 16:05:48 2018
New Revision: 332783
URL: https://svnweb.freebsd.org/changeset/base/332783

Log:
  Reword comment to remove awkward constructs, including an "it's" that
  shouldn't have been there at all (it wasn't a typo for its, rather a
  left-over from an older revision of the comment).
  
  Noticed by: many

Modified:
  head/sys/dev/nvme/nvme_ns.c

Modified: head/sys/dev/nvme/nvme_ns.c
==============================================================================
--- head/sys/dev/nvme/nvme_ns.c	Thu Apr 19 16:00:34 2018	(r332782)
+++ head/sys/dev/nvme/nvme_ns.c	Thu Apr 19 16:05:48 2018	(r332783)
@@ -506,10 +506,9 @@ nvme_ns_construct(struct nvme_namespace *ns, uint32_t 
 	ns->stripesize = 0;
 
 	/*
-	 * Some Intel devices advertise an alignment that improves performance,
-	 * but is in it's vendor specific space in the cdata. Use it for these
-	 * drives, if present, to suggest a stripe size.  Future versions of
-	 * Intel hardware will use fields standardized in NVMe 1.3 for this.
+	 * Older Intel devices advertise in vendor specific space an alignment
+	 * that improves performance.  If present use for the stripe size.  NVMe
+	 * 1.3 standardized this as NOIOB, and newer Intel drives use that.
 	 */
 	switch (pci_get_devid(ctrlr->dev)) {
 	case 0x09538086:		/* Intel DC PC3500 */


More information about the svn-src-head mailing list