svn commit: r332104 - head/sys/dev/ipmi

[Jonathan T. Looney]

Author: jtl
Date: Fri Apr  6 15:15:21 2018
New Revision: 332104
URL: https://svnweb.freebsd.org/changeset/base/332104

Log:
  In cases where an application issues certain IPMI commands at a high
  enough rate, the IPMI code can print large numbers of messages to the
  console, such as:
    ipmi0: KCS: Failed to read completion code
    ipmi0: KCS error: ff
    ipmi0: KCS: Failed to read completion code
    ipmi0: KCS error: ff
  
  These seem to be innocuous from a system standpoint, and the user-
  space code can deal with the failures. Therefore, suppress printing
  these messages to the console unless bootverbose is enabled.
  
  Obtained from:	Netflix, Inc.

Modified:
  head/sys/dev/ipmi/ipmi_kcs.c

Modified: head/sys/dev/ipmi/ipmi_kcs.c
==============================================================================
--- head/sys/dev/ipmi/ipmi_kcs.c	Fri Apr  6 15:09:30 2018	(r332103)
+++ head/sys/dev/ipmi/ipmi_kcs.c	Fri Apr  6 15:15:21 2018	(r332104)
@@ -150,7 +150,7 @@ kcs_error(struct ipmi_softc *sc)
 
 			/* Read error status */
 			data = INB(sc, KCS_DATA);
-			if (data != 0)
+			if (data != 0 && (data != 0xff || bootverbose))
 				device_printf(sc->ipmi_dev, "KCS error: %02x\n",
 				    data);
 
@@ -416,8 +416,10 @@ kcs_polled_request(struct ipmi_softc *sc, struct ipmi_
 
 	/* Next we read the completion code. */
 	if (kcs_read_byte(sc, &req->ir_compcode) != 1) {
-		device_printf(sc->ipmi_dev,
-		    "KCS: Failed to read completion code\n");
+		if (bootverbose) {
+			device_printf(sc->ipmi_dev,
+			    "KCS: Failed to read completion code\n");
+		}
 		goto fail;
 	}
 #ifdef KCS_DEBUG