svn commit: r323991 - head/sys/boot/efi/libefi

Toomas Soome tsoome at FreeBSD.org
Mon Sep 25 19:49:58 UTC 2017


Author: tsoome
Date: Mon Sep 25 19:49:56 2017
New Revision: 323991
URL: https://svnweb.freebsd.org/changeset/base/323991

Log:
  libefi: efipart_floppy() will should not pass acpi pointer if the HID test fails
  
  The current efipart_floppy() implementation is leaking the acpi pointer.

Modified:
  head/sys/boot/efi/libefi/efipart.c

Modified: head/sys/boot/efi/libefi/efipart.c
==============================================================================
--- head/sys/boot/efi/libefi/efipart.c	Mon Sep 25 19:33:32 2017	(r323990)
+++ head/sys/boot/efi/libefi/efipart.c	Mon Sep 25 19:49:56 2017	(r323991)
@@ -181,7 +181,7 @@ efipart_inithandles(void)
 static ACPI_HID_DEVICE_PATH *
 efipart_floppy(EFI_DEVICE_PATH *node)
 {
-	ACPI_HID_DEVICE_PATH *acpi = NULL;
+	ACPI_HID_DEVICE_PATH *acpi;
 
 	if (DevicePathType(node) == ACPI_DEVICE_PATH &&
 	    DevicePathSubType(node) == ACPI_DP) {
@@ -192,7 +192,7 @@ efipart_floppy(EFI_DEVICE_PATH *node)
 			return (acpi);
 		}
 	}
-	return (acpi);
+	return (NULL);
 }
 
 /*


More information about the svn-src-head mailing list