svn commit: r323359 - in head/sys: conf dev/uart modules/uart

[Sean Bruno]

On 09/09/17 12:20, Ian Lepore wrote:
> On Sat, 2017-09-09 at 12:09 -0600, Sean Bruno wrote:
>>
>> On 09/09/17 05:42, Marcin Wojtas wrote:
>>>
>>> Author: mw
>>> Date: Sat Sep  9 11:42:32 2017
>>> New Revision: 323359
>>> URL: https://svnweb.freebsd.org/changeset/base/323359
>>>
>>> Log:
>>>   Introduce UART driver module for Armada 3700
>>>   
>>>   This patch adds support for UART in Armada 3700 family.
>>>   It exposes both low-level UART interface, as well as
>>>   standard driver methods.
>>>   
>>>   Submitted by: Patryk Duda <pdk at semihalf.com>
>>>   Obtained from: Semihalf
>>>   Sponsored by: Semihalf
>>>   Differential Revision: https://reviews.freebsd.org/D12250
>>>
>>> Added:
>>>   head/sys/dev/uart/uart_dev_mvebu.c   (contents, props changed)
>>> Modified:
>>>   head/sys/conf/files
>>>   head/sys/modules/uart/Makefile
>>
>> Hrm ... I seem to be getting a compile failure after this:
>>
>> cc -target x86_64-unknown-freebsd12.0 --sysroot=/var/tmp/usr/src/tmp
>> -B/var/tmp/usr/src/tmp/usr/bin  -O2 -pipe  -fno-strict-aliasing
>> -Werror
>> -D_KERNEL -DKLD_MODULE -nostdinc   -DHAVE_KERNEL_OPTION_HEADERS
>> -include
>> /var/tmp/usr/src/sys/GENERIC-NODEBUG/opt_global.h -I. -I/usr/src/sys
>> -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
>> -I/var/tmp/usr/src/sys/GENERIC-NODEBUG   -MD
>> -MF.depend.uart_dev_mvebu.o -MTuart_dev_mvebu.o -mcmodel=kernel
>> -mno-red-zone -mno-mmx -mno-sse -msoft-float
>> -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-
>> protector
>> -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-
>> prototypes
>> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef
>> -Wno-pointer-sign -D__printf__=__freebsd_kprintf__
>> -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas
>> -Wno-error-tautological-compare -Wno-error-empty-body
>> -Wno-error-parentheses-equality -Wno-error-unused-function
>> -Wno-error-pointer-sign -Wno-error-shift-negative-value
>> -Wno-error-address-of-packed-member  -mno-aes -mno-avx
>> -std=iso9899:1999 -c /usr/src/sys/dev/uart/uart_dev_mvebu.c -o
>> uart_dev_mvebu.o
>> In file included from /usr/src/sys/dev/uart/uart_dev_mvebu.c:39:
>> /usr/src/sys/dev/ofw/ofw_bus_subr.h:40:10: fatal error:
>> 'ofw_bus_if.h'
>> file not found
>> #include "ofw_bus_if.h"
>>          ^~~~~~~~~~~~~~
>> 1 error generated.
>> *** Error code 1
>>
>> Is there supposed to be processing of ofw_bus_if.m somewhere that is
>> currently missed?
>>
>> sean
>>
> 
> ofw_bus_if.h needs to be added to SRCS= in the module makefile.  Over
> the years I learned to grep the c files for _if.h to figure out what
> generated files to add to a module makefile, but ofw_bus_if.h is
> insidious -- it gets included from ofw_bus_subr.h so nobody includes it
> directly and it always gets missed in new module makefiles.
> 
> -- Ian
> 
> 
> 


Oh, the SRCS entry *is* in sys/modules/uart/Makefile but not for x86
archs.  Should this even be built for x86?

sean

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20170909/39cd897f/attachment.sig>