svn commit: r324811 - in head/sys/dev/pms/freebsd/driver: common ini/src

Ryan Libby rlibby at freebsd.org
Sat Oct 21 08:10:39 UTC 2017


On Sat, Oct 21, 2017 at 12:43 AM, Ngie Cooper (yaneurabeya)
<yaneurabeya at gmail.com> wrote:
>
>> On Oct 21, 2017, at 00:23, Ryan Libby <rlibby at FreeBSD.org> wrote:
>>
>> Author: rlibby
>> Date: Sat Oct 21 07:23:45 2017
>> New Revision: 324811
>> URL: https://svnweb.freebsd.org/changeset/base/324811
>>
>> Log:
>>  pms/freebsd: fix compiler warnings
>>
>>   - A number of unused variable warnings,
>>   - a missing prototype warning (actually a dead function),
>>   - and a potential use of an uninitialized variable.
>
> You probably should look for the other _fantastic_ fixes that Danny Ryan cooked up for the driver. I don’t think you’ve found the branches that result in logic errors which trigger corruption yet…
> Cheers,
> -Ngie

Thanks, I will ping him.  Yes, this is just from clang and gcc warnings
and of that just for what's under sys/dev/pms/freebsd.

I also have patches for fixes for warnings across sys/dev/pms, and pfg
has a spelling fixup patch.

There seems to be a little uncertainty about how to proceed wrt
maintenance of the driver, so I won't be pushing those changes until
that is clarified.  (Is freebsd the de facto upstream now?)


More information about the svn-src-head mailing list