svn commit: r324501 - head/sys/dev/acpica/Osd

Jung-uk Kim jkim at FreeBSD.org
Tue Oct 10 19:20:40 UTC 2017


Author: jkim
Date: Tue Oct 10 19:20:38 2017
New Revision: 324501
URL: https://svnweb.freebsd.org/changeset/base/324501

Log:
  Do not check whether AcpiOsGetTimer() is called during boot.
  
  From ACPICA 20170929, AcpiOsGetTimer() should be available early because
  While() loop timeout mechanism was reimplemented with it.  Unfortunately,
  it means AcpiLoadTables() may cause panic when a While() loop is executed.
  After having lengthy discussions with ACPICA developers, I have concluded
  that dummy timecounter is good enough for the purpose and it is the least
  intrusive solution for now.  Also, they reminded me the ACPI specification
  implies OS timer function should be available before loading tables.

Modified:
  head/sys/dev/acpica/Osd/OsdSchedule.c

Modified: head/sys/dev/acpica/Osd/OsdSchedule.c
==============================================================================
--- head/sys/dev/acpica/Osd/OsdSchedule.c	Tue Oct 10 19:14:40 2017	(r324500)
+++ head/sys/dev/acpica/Osd/OsdSchedule.c	Tue Oct 10 19:20:38 2017	(r324501)
@@ -274,9 +274,6 @@ AcpiOsGetTimer(void)
     struct bintime bt;
     UINT64 t;
 
-    /* XXX During early boot there is no (decent) timer available yet. */
-    KASSERT(cold == 0, ("acpi: timer op not yet supported during boot"));
-
     binuptime(&bt);
     t = (uint64_t)bt.sec * 10000000;
     t += ((uint64_t)10000000 * (uint32_t)(bt.frac >> 32)) >> 32;


More information about the svn-src-head mailing list