svn commit: r324406 - head/sys/modules/em

[Rodney W. Grimes]

> 
> > On Oct 7, 2017, at 16:33, Sean Bruno <sbruno at FreeBSD.org> wrote:
> > 
> > Author: sbruno
> > Date: Sat Oct  7 23:33:14 2017
> > New Revision: 324406
> > URL: https://svnweb.freebsd.org/changeset/base/324406
> > 
> > Log:
> >  Fix symlink if_igb.ko in -current such that its relative and doesn't
> >  end up with non-standard DESTDIR information in its symlink.  This
> >  can happen very trivially if the release scripts are used.
> > 
> >  Sponsored by:    Limelight Networks
> > 
> > Modified:
> >  head/sys/modules/em/Makefile
> > 
> > Modified: head/sys/modules/em/Makefile
> > ==============================================================================
> > --- head/sys/modules/em/Makefile    Sat Oct  7 23:30:57 2017    (r324405)
> > +++ head/sys/modules/em/Makefile    Sat Oct  7 23:33:14 2017    (r324406)
> > @@ -23,6 +23,6 @@ CFLAGS += -I${SRCTOP}/sys/dev/e1000
> > #CFLAGS  += -DDEVICE_POLLING
> > 
> > afterinstall:
> > -    ln -sf ${DESTDIR}${KMODDIR}/${KMOD}.ko ${DESTDIR}${KMODDIR}/if_igb.ko
> > +    cd ${DESTDIR}${KMODDIR} && ln -sf if_em.ko if_igb.ko
> 
> While this is definitely better, the same thing could be achieved via:
> 
> ln -sf if_em.ko ${DESTDIR}/.../if_igb.ko

Should this be using SYMLINK+= as I thought using ln -sf was a breakage
for meta mode stuff?

-- 
Rod Grimes                                                 rgrimes at freebsd.org