svn commit: r326218 - head/sys/kern

Hans Petter Selasky hps at selasky.org
Wed Nov 29 15:36:47 UTC 2017


Hi Nathan,

The chunk below causes sched_pin() to stop working and should be removed 
from your commit ??!!

It probably explains the hangs seen recently reported by various brave 
people running 12-current :-)

Specifically I see threads migrating between CPUs when td->td_pinned > 0 
using the LinuxKPI RCU API, which in turn leads to a hang when trying to 
synchronize RCU.

--HPS

diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c
index 5c8bae5afa1..bd4b505f6c3 100644
--- a/sys/kern/sched_ule.c
+++ b/sys/kern/sched_ule.c
@@ -2453,7 +2453,7 @@ sched_add(struct thread *td, int flags)
          * Pick the destination cpu and if it isn't ours transfer to the
          * target cpu.
          */
-       td_get_sched(td)->ts_cpu = curcpu; /* Pick something valid to 
start */
+//     td_get_sched(td)->ts_cpu = curcpu; /* Pick something valid to 
start */
         cpu = sched_pickcpu(td, flags);
         tdq = sched_setcpu(td, cpu, flags);
         tdq_add(tdq, td, flags);


More information about the svn-src-head mailing list