svn commit: r325793 - head/sys/dev/pci

Warner Losh imp at bsdimp.com
Wed Nov 15 02:25:01 UTC 2017


On Tue, Nov 14, 2017 at 10:00 AM, Warner Losh <imp at bsdimp.com> wrote:

>
>
> On Tue, Nov 14, 2017 at 8:47 AM, John Baldwin <jhb at freebsd.org> wrote:
>
>> On Tuesday, November 14, 2017 05:05:05 AM Warner Losh wrote:
>> > Author: imp
>> > Date: Tue Nov 14 05:05:05 2017
>> > New Revision: 325793
>> > URL: https://svnweb.freebsd.org/changeset/base/325793
>> >
>> > Log:
>> >   Provide pcie_link_status and pcie_link_cap convenience functions.
>> >
>> >   Sponsored by: Netflix
>>
>> Note that we already have pcie_read_config() (documented in the manpage).
>> With pcie_read_config() these would be one liners:
>>
>> pcie_link_status() -> pcie_read_config(dev, PCIER_LINK_STA, 2);
>>
>> This is what the existing hotplug code uses rather than having dedicated
>> functions for each PCI-e register.
>>
>> New functions should be documented in pci.9.
>>
>
> Thanks for the reminders. I'll either transition to the one liner you
> talked about, or  document the new functions.
>

Good suggestion. I've implemented this instead in r325838

Warner


More information about the svn-src-head mailing list