svn commit: r325386 - head/sys/kern

Konstantin Belousov kostikbel at gmail.com
Sun Nov 5 20:15:13 UTC 2017


On Sun, Nov 05, 2017 at 12:37:50PM -0700, Ian Lepore wrote:
> IMO, the only reason ASSERT-style macros exist is to hide the
> conditional-on-build-type part of the operation.  That is, to avoid
> having #ifdef INVARIANTS scattered everywhere.
bde' point is that KASSERT() is badly designed, and I agree with him.
Now we could at least remove the () around the message formatting part,
but it is too late.

> 
> Creating a macro to generate always-on error detection and reporting
> code just because there exists a macro to do so conditionally seems to
> turn the world on its head.
I agree with this statement.  if()panic(); construct is good enough, IMO.


More information about the svn-src-head mailing list