svn commit: r318922 - head/sys/cddl/contrib/opensolaris

Andriy Gapon avg at FreeBSD.org
Fri May 26 10:34:34 UTC 2017


Author: avg
Date: Fri May 26 10:34:33 2017
New Revision: 318922
URL: https://svnweb.freebsd.org/changeset/base/318922

Log:
  MFV r316927: 5379 modifying a mmap()-ed file does not update its timestamps
  
  FreeBSD note: this is a record-only merge as the FreeBSD putpages code
  is quite different from the upstream.
  
  illumos/illumos-gate at 80e10fd0d22bbf0d18bfdae035e06f44c68ae8e6
  https://github.com/illumos/illumos-gate/commit/80e10fd0d22bbf0d18bfdae035e06f44c68ae8e6
  
  https://www.illumos.org/issues/5379
    The following is based on a review of the illumos code and on a similar problem
    reported for FreeBSD where the relevant code is different.
    Looking at this block of code http://src.illumos.org/source/xref/illumos-gate/
    usr/src/uts/common/fs/zfs/zfs_vnops.c#4187 I see code to set up an
    sa_bulk_attr_t object, I see code to set up mtime and ctime values, but I do
    not see code to actually apply the attributes...
    I would expect there to be a call to sa_bulk_update(), there is such a call in
    zfs_write() for instance.
    mmap_write.c [Magnifier] - demo (1.42 KB) Andriy Gapon, 2015-11-11 01:53 PM
  
  Reviewed by: Matthew Ahrens <mahrens at delphix.com>
  Reviewed by: Prashanth Sreenivasa <pks at delphix.com>
  Reviewed by: Dan McDonald <danmcd at omniti.com>
  Approved by: Gordon Ross <gordon.w.ross at gmail.com>
  Author: Andriy Gapon <andriy.gapon at clusterhq.com>

Modified:
Directory Properties:
  head/sys/cddl/contrib/opensolaris/   (props changed)


More information about the svn-src-head mailing list