svn commit: r318736 - in head: cddl/lib/libzfs contrib/compiler-rt/lib/sanitizer_common contrib/openbsm/libbsm include lib/libarchive lib/libc/gen lib/libc/include lib/libc/sys lib/libkvm lib/libmi...

[Ed Maste]

On 24 May 2017 at 10:53, Pedro Giffuni <pfg at freebsd.org> wrote:
>
> There is now a bunch of coverity issues (OVERFLOW_BEFORE_WIDEN mostly)
> tied to ino64_t. At least the following CIDs are related:

On a quick look the OVERFLOW_BEFORE_WIDEN issues are false positives
in practice: for correct operation the product must fit within 32
bits, because inodes were previously 32 bits. However, it does seem
unusual to perform a multiplication with types that could overflow 32
bits, and then store the result in a 64-bit variable. So it seems that
a code change to eliminate the warning is likely reasonable.