svn commit: r318166 - head/sys/netinet

Gleb Smirnoff glebius at FreeBSD.org
Wed May 10 23:32:32 UTC 2017


Author: glebius
Date: Wed May 10 23:32:31 2017
New Revision: 318166
URL: https://svnweb.freebsd.org/changeset/base/318166

Log:
  There is no good reason for TCP reassembly zone to be UMA_ZONE_NOFREE.
  
  It has strong locking model, doesn't have any timers associated with
  entries.  The entries theirselves are referenced only from the tcpcb zone,
  which itself is a normal zone, without the UMA_ZONE_NOFREE flag.

Modified:
  head/sys/netinet/tcp_reass.c

Modified: head/sys/netinet/tcp_reass.c
==============================================================================
--- head/sys/netinet/tcp_reass.c	Wed May 10 23:14:09 2017	(r318165)
+++ head/sys/netinet/tcp_reass.c	Wed May 10 23:32:31 2017	(r318166)
@@ -108,7 +108,7 @@ tcp_reass_global_init(void)
 	TUNABLE_INT_FETCH("net.inet.tcp.reass.maxsegments",
 	    &tcp_reass_maxseg);
 	tcp_reass_zone = uma_zcreate("tcpreass", sizeof (struct tseg_qent),
-	    NULL, NULL, NULL, NULL, UMA_ALIGN_PTR, UMA_ZONE_NOFREE);
+	    NULL, NULL, NULL, NULL, UMA_ALIGN_PTR, 0);
 	/* Set the zone limit and read back the effective value. */
 	tcp_reass_maxseg = uma_zone_set_max(tcp_reass_zone,
 	    tcp_reass_maxseg);


More information about the svn-src-head mailing list