svn commit: r316064 - head/sys/boot/i386/boot2

[Bruce Evans]

On Tue, 28 Mar 2017, Warner Losh wrote:

> [[ sorry for the top post but it's quick ]]

It's quicker and almost equivalent to delete what you reply to.

> Summary, in Bruce's own words
>
>> the whole optimization step was silly.
>
> I agree. on my -current system, clang compiled boot2 was 4 bytes
> smaller after ripping it out. gcc was a whopping 7 bytes larger. Since
> gcc has 156 still free, I think it's best to just retire this.
>
> Maybe you can give me a hint as to which structs to look at to get
> back those 7 bytes :)

Just sort the character arrays to get back 4.  Maybe clang already does
this, though I like getting the same order as in the sources.

Reducing 1 of the arrays by 1 byte would then save 1 and get back the
other 3.

Bruce