svn commit: r308996 - head/lib/libfetch

Dag-Erling Smørgrav des at des.no
Sun Mar 12 11:26:35 UTC 2017


"Ngie Cooper (yaneurabeya)" <yaneurabeya at gmail.com> writes:
> Hi Bjoern,

No, that was my father :)

> 	Shouldn’t this be strrchr instead of strchr since you’re
> scanning for the service from the right side of the host,
> e.g. “foo:service” or “[::1]:service”? This code would match index 3
> in the first example, but it would match index 2 in the second
> example.

Correct, although it may be slightly more complicated, which is why I
didn't immediately jump on it when bz@ pointed it out.  I'm working on
it right now.

DES
-- 
Dag-Erling Smørgrav - des at des.no


More information about the svn-src-head mailing list