svn commit: r315068 - head/sys/modules/qlxgbe

Andriy Gapon avg at FreeBSD.org
Sun Mar 12 09:32:32 UTC 2017


On 12/03/2017 04:44, Bruce Evans wrote:
> On Sat, 11 Mar 2017, Andriy Gapon wrote:
> 
>> Log:
>>  revert r314862, use of GCC_MS_EXTENSIONS in qlxgbe
>>
>>  Commit r278913 made explicit use of GCC_MS_EXTENSIONS  unnecessary.
>>
>>  Requested by:    glebius
> 
> Does this module actually use ms extensions?  This seems unlikely, since
> only gcc supports them.

It probably doesn't.

> My kernels compile correctly with the correct CFLAGS (gcc -std=gnu99
> -fno-ms-extensions).

How did you manage to pass -std=gnu99 to the module build?
No matter what flags I tried to modify the actual compiler invocations still had
-std=iso9899:1999 after -std=gnu99 in them, so my modifications had no effect.
GCC_MS_EXTENSIONS was the easiest way to get the job done.

-- 
Andriy Gapon


More information about the svn-src-head mailing list