svn commit: r311849 - in head: . sys/amd64/conf sys/arm64/conf sys/conf sys/dev/e1000 sys/i386/conf sys/mips/conf sys/modules sys/modules/em sys/modules/igb sys/powerpc/conf

[Warner Losh]

It's already in loader.hints. The bug is that ifconfig doesn't use a
library (which others can use) to find the module by name, but rather
assumes a particular filename -> module name mapping.

Warner

On Fri, Mar 10, 2017 at 1:07 PM, Adrian Chadd <adrian.chadd at gmail.com> wrote:
> s/ifconfig/put-it-in-a-config-file-in-share-so-we-dont-have-to-patch-ifconfig-every-time-we-change-this-kthxbai/g
>
>
> -adrian
>
>
> On 10 March 2017 at 11:12, Navdeep Parhar <nparhar at gmail.com> wrote:
>> On Fri, Mar 10, 2017 at 10:41 AM, Ryan Stone <rysto32 at gmail.com> wrote:
>>> There's also the issue that running "ifconfig igb0 blah" during startup will
>>> cause if_igb to be automatically loaded by ifconfig.
>>>
>>> I guess we could add a dummy if_igb.ko that just has a dependency on
>>> if_em.ko
>>
>> I do similar stuff in cxgbe (if_cxl.ko and if_cc.ko exist solely to
>> drag in if_cxgbe.ko as a dependency).  In hindsight I wish I'd just
>> added a list of ifnet names -> kld map to ifconfig instead.  It would
>> have been an ugly hack but much simpler.
>>
>> Regards,
>> Navdeep
>>
>>>
>>> On Fri, Mar 10, 2017 at 1:13 PM, Warner Losh <imp at bsdimp.com> wrote:
>>>>
>>>> On Fri, Mar 10, 2017 at 11:06 AM, Sean Bruno <sbruno at freebsd.org> wrote:
>>>> >
>>>> >
>>>> > On 02/15/17 03:06, Roger Pau Monné wrote:
>>>> >> On Tue, Jan 10, 2017 at 03:23:22AM +0000, Sean Bruno wrote:
>>>> >>> Author: sbruno
>>>> >>> Date: Tue Jan 10 03:23:22 2017
>>>> >>> New Revision: 311849
>>>> >>> URL: https://svnweb.freebsd.org/changeset/base/311849
>>>> >>>
>>>> >>> Log:
>>>> >>>   Migrate e1000 to the IFLIB framework:
>>>> >>>   - em(4) igb(4) and lem(4)
>>>> >>>   - deprecate the igb device from kernel configurations
>>>> >>>   - create a symbolic link in /boot/kernel from if_em.ko to if_igb.ko
>>>> >>
>>>> >> This linking causes mfsBSD to choke when building an image from HEAD.
>>>> >> It tries
>>>> >> to issue the following command:
>>>> >>
>>>> >> ${_v}${CP} -rp ${_BOOTDIR}/kernel ${WRKDIR}/disk/boot
>>>> >>
>>>> >> Which fails when finding the symbol link. I can send a patch to change
>>>> >> that to
>>>> >> -Rp, which would work fine, but wouldn't it be better to either
>>>> >> completely
>>>> >> remove if_igb.ko, or simply copy if_em.ko to if_igb.ko?
>>>> >>
>>>> >> I'm wondering if for example anyone strips down it's /boot/kernel/
>>>> >> manually, by
>>>> >> removing unused modules, and what would happen if if_em.ko is removed
>>>> >> but not
>>>> >> if_igb.ko.
>>>> >>
>>>> >> Roger.
>>>> >>
>>>> >>
>>>> >
>>>> > Well, this was my naive attempt to make upgrades for users to be
>>>> > non-eventful in the event they have "if_igb_load=YES" in their
>>>> > loader.conf instead of having it built into their kernel.
>>>> >
>>>> > If the -Rp works, I'll add that instead.
>>>>
>>>> The module name is encoded in the module itself. The boot loader looks
>>>> it up to see which module to load. Maybe there's a way to fix it so
>>>> both load from one file?
>>>>
>>>> Warner
>>>>
>>>
>>