svn commit: r314961 - head/usr.bin/localedef

[Warner Losh]

On Thu, Mar 9, 2017 at 8:37 AM, Pedro Giffuni <pfg at freebsd.org> wrote:
>
> On 3/9/2017 10:26 AM, Rodney W. Grimes wrote:
>>>
>>> Author: pfg
>>> Date: Thu Mar  9 15:21:03 2017
>>> New Revision: 314961
>>> URL: https://svnweb.freebsd.org/changeset/base/314961
>>>
>>> Log:
>>>    localedef(1): Fix for memory leaks reported by coverity.
>>>       Also some small cleanups to match better current illumos.
>>>       CID: 1338540, 1338541, 1338557, 1338566
>>>       Obtained from:    illumos
>>>    Discussed with:      Yuri Pankov (@Nexenta)
>>>    MFC after:   5 days
>>>
>>> Modified:
>>>    head/usr.bin/localedef/collate.c
>>>    head/usr.bin/localedef/ctype.c
>>>    head/usr.bin/localedef/localedef.c
>>>    head/usr.bin/localedef/localedef.h
>>>    head/usr.bin/localedef/time.c
>>>
>>> Modified: head/usr.bin/localedef/collate.c
>>>
>>> ==============================================================================
>>> --- head/usr.bin/localedef/collate.c    Thu Mar  9 13:41:57 2017
>>> (r314960)
>>> +++ head/usr.bin/localedef/collate.c    Thu Mar  9 15:21:03 2017
>>> (r314961)
>>> @@ -1,5 +1,5 @@
>>>   /*
>>> - * Copyright 2010 Nexenta Systems, Inc.  All rights reserved.
>>> + * Copyright 2017 Nexenta Systems, Inc.
>>
>> Now this is defanitly a wrong thing to do with a copyright notice,
>> always error on the side of OLDEST date, never newest.  You have now
>> extended Nexenta's claim to 2010 work by 7 years.
>>
> Which is fine.
> Nexenta was so really nice to relicense this from CDDL to BSD, just for us.

That was nice of Nexenta. We shouldn't harp on them in return for
conducting their business in a way that's different from how we'd
conduct ours. The copyright belongs to them. It's their duty to report
and mark their works in accordance to their best interests, including
complying with bits of the law. We should let them do it because it is
none of our concern. We should not repay their kindness with needless
whining.

Warner