svn commit: r314862 - head/sys/modules/qlxgbe

[Ngie Cooper (yaneurabeya)]

> On Mar 8, 2017, at 13:55, Gleb Smirnoff <glebius at FreeBSD.org> wrote:
> 
> On Wed, Mar 08, 2017 at 01:00:30AM +0200, Andriy Gapon wrote:
> A> On 08/03/2017 00:17, Gleb Smirnoff wrote:
> A> > On Tue, Mar 07, 2017 at 03:43:49PM +0000, Andriy Gapon wrote:
> A> > A> Author: avg
> A> > A> Date: Tue Mar  7 15:43:49 2017
> A> > A> New Revision: 314862
> A> > A> URL: https://svnweb.freebsd.org/changeset/base/314862
> A> > A>
> A> > A> Log:
> A> > A>   qlxgbe: add GCC_MS_EXTENSIONS to CFLAGS to make old base GCC happy
> A> > A>
> A> > A>   The module uses unnamed structure and union fields and base GCC in
> A> > A>   stable/10 doesn't like it.
> A> > A>   I think that that is a C11 feature, so it is courteous of more modern
> A> > A>   compilers to not complain about it when compiling in C99 mode.
> A> >
> A> > There are a lot of code in kernel, that uses anonymous structs and unions.
> A> > This feature is enabled globally. Why does this module need special treatment?
> A>
> A> That's a good question and I don't have a good answer to it.
> A> All I can say is that a GCC build of GENERIC and modules failed in that fashion
> A> only for this module (in stable/10).
> A> Maybe I described the problem incorrectly.  Then, a proper explanation is welcome.
> 
> In head this is fixed properly:
> 
> https://svnweb.freebsd.org/base?view=revision&revision=278913
> 
> Can you please move your fix to stable/10 and revert it in head?

I understand there might be conflicts, but wouldn’t it be better to revert and MFC the change you committed to ^/head (which is already in ^/stable/11) to ^/stable/10?
Thanks,
-Ngie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20170308/b5516342/attachment.sig>