svn commit: r314891 - head/sys/boot/efi/loader

[Dexuan Cui]

> From: Rodney W. Grimes [mailto:freebsd at pdx.rh.CN85.dnsmgr.net]
> Sent: Wednesday, March 8, 2017 12:33
> > Author: dexuan
> > Date: Wed Mar  8 02:50:29 2017
> > New Revision: 314891
> > Log:
> >   loader.efi: finally fix the off-by-one bug in efi_verify_staging_size()
> >
> >   r314828(loader.efi: fix an off-by-one bug in efi_verify_staging_size())
> >   doesn't really fix the bug and this patch adds the missing part.
> >
> >   It's a shame that I didn't make everything correct at the very beginning...
> 
> My thoughts on that:
> 
> Try as hard as we can and you well come up short on making software
> correct in the beginning as it is an iterative process.  Be glad you
> have found and fixed yet another small problem, and hope that in
> doing so you have not introduced another.
> 
> I thank you for your persuit of this latent issue in loader.efi!
> --
> Rod Grimes  

The lesson I learned here is that: do test the code with real test cases,
no matter how confident I'm in the patch, and no matter how small
the change would look like.

And another issue here is that actually I don't have a local physical
FreeBSD machine yet. Trying to set up one.

Thanks,
-- Dexuan