svn commit: r314813 - head/sys/kern

[Conrad Meyer]

Hi Hiren,

On Mon, Mar 6, 2017 at 4:20 PM, Hiren Panchasara <hiren at freebsd.org> wrote:
> Author: hiren
> Date: Tue Mar  7 00:20:01 2017
> New Revision: 314813
> URL: https://svnweb.freebsd.org/changeset/base/314813
>
> ...
> @@ -1043,6 +1043,11 @@ sbcut_internal(struct sockbuf *sb, int l
>  {
>         struct mbuf *m, *next, *mfree;
>
> +       KASSERT(len > 0, ("%s: len is %d but it is supposed to be +ve",
> +           __func__, len));

Can you change the spelling from +ve to positive?  I guess that might
mean wrapping the line, but I find the full word much more clear.
(Also, I guess the assert is >= 0 now?  So that should read
"non-negative" rather than "positive." :-) )


> +       KASSERT(len <= sb->sb_ccc, ("%s: len: %d is > ccc: %u",
> +           __func__, len, sb->sb_ccc));
> +
>         next = (m = sb->sb_mb) ? m->m_nextpkt : 0;
>         mfree = NULL;

Best,
Conrad