svn commit: r314666 - head/sys/dev/ioat

[Andriy Gapon]

On 04/03/2017 14:51, Andriy Gapon wrote:
> Author: avg
> Date: Sat Mar  4 12:51:57 2017
> New Revision: 314666
> URL: https://svnweb.freebsd.org/changeset/base/314666
> 
> Log:
>   ioat: don't specify inline for function with variable argument list
>   
>   Modern GCC and Clang simply ignore the qualifier, while the old base GCC
>   produces a warning (treated as an error in the kernel build).

Just in case, here is the exact error that I see:
ioat_test.c:593: warning: function '_ioat_test_log' can never be inlined because
it uses variable argument lists [-Winline]

>   Approved by:	cem
>   MFC after:	5 days
> 
> Modified:
>   head/sys/dev/ioat/ioat_test.c
> 
> Modified: head/sys/dev/ioat/ioat_test.c
> ==============================================================================
> --- head/sys/dev/ioat/ioat_test.c	Sat Mar  4 12:42:52 2017	(r314665)
> +++ head/sys/dev/ioat/ioat_test.c	Sat Mar  4 12:51:57 2017	(r314666)
> @@ -79,7 +79,7 @@ static int g_thread_index = 1;
>  static struct cdev *g_ioat_cdev = NULL;
>  
>  #define	ioat_test_log(v, ...)	_ioat_test_log((v), "ioat_test: " __VA_ARGS__)
> -static inline void _ioat_test_log(int verbosity, const char *fmt, ...);
> +static void _ioat_test_log(int verbosity, const char *fmt, ...);
>  
>  static void
>  ioat_test_transaction_destroy(struct test_transaction *tx)
> @@ -579,7 +579,7 @@ ioat_test_detach(void)
>  	mtx_unlock(&Giant);
>  }
>  
> -static inline void
> +static void
>  _ioat_test_log(int verbosity, const char *fmt, ...)
>  {
>  	va_list argp;
> 


-- 
Andriy Gapon