svn commit: r314464 - head/usr.sbin/yppush

[Baptiste Daroussin]

On Wed, Mar 01, 2017 at 02:41:23PM -0800, Ngie Cooper wrote:
> On Wed, Mar 1, 2017 at 9:08 AM, Rodney W. Grimes
> <freebsd-rwg at pdx.rh.cn85.dnsmgr.net> wrote:
> ...
> > At one point in history I can promise you that ALL symlinks in the release
> > where shortest possible relative path.  So any absolute links that entered
> > the system got created by developers who where not aware that they should
> > always use a relative link for anything landing in DESTDIR.  This creates
> > breakge on so many levels we should make a rapid correction to this
> > regression.
> 
> This is why things are that way currently:
> 
> $ git blame usr.bin/chpass/Makefile| grep ypchfn
> 780ae7713f72b (gjb     2016-01-28 01:15:57 +0000 29) SYMLINKS+=
> ${BINDIR}/chpass ${BINDIR}/ypchfn
> aca2488187113 (wosch   1997-09-13 12:21:25 +0000 35) MLINKS+= chpass.1
> ypchpass.1 chpass.1 ypchfn.1 chpass.1 ypchsh.1
> 5294f47313a2d (gjb     2016-01-28 02:56:30 +0000 39) .for i in chpass
> chfn chsh ypchpass ypchfn ypchsh

For thos in particular I think the right thing is actually to modify install so
if it creates hardlinks with chflags it should first check for chflags, remove
it make the hardlink and reapply. The issue would be that well you break what
chflags are for given you are workarounding it :)

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20170302/1c990cd7/attachment.sig>