svn commit: r320277 - head/usr.bin/mkuzip

[Ngie Cooper (yaneurabeya)]

> On Jun 23, 2017, at 16:51, Glen Barber <gjb at FreeBSD.org> wrote:
> 
> On Fri, Jun 23, 2017 at 03:54:35PM -0700, Conrad Meyer wrote:
>>> @@ -58,12 +59,15 @@ mkuz_get_insize(struct mkuz_cfg *cfp)
>>>                ffd = open(statfsbuf.f_mntfromname, O_RDONLY);
>>>                if (ffd < 0) {
>>>                        warn("open(%s, O_RDONLY)", statfsbuf.f_mntfromname);
>>> +                       close(ffd);
>> 
>> This one is wrong for obvious reasons.
>> 
> 
> It isn't obvious to me.  :)

open failed, so closing ffd == -1 is a programming error (but admittedly, pretty benign).
-Ngie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20170624/d8ee936a/attachment.sig>