svn commit: r319868 - in head/sys: kern sys

Konstantin Belousov kostikbel at gmail.com
Mon Jun 12 20:30:03 UTC 2017


On Mon, Jun 12, 2017 at 08:14:44PM +0000, Mark Johnston wrote:
> +int
> +uuidcmp(const struct uuid *uuid1, const struct uuid *uuid2)
> +{
> +
> +	return (memcmp(uuid1, uuid2, sizeof(struct uuid)));
> +}

This is unsafe.  The function operation depends on the ABI properties
that there is no padding either between members, or at the end of
the structure.  Why not use by-member comparision ?


More information about the svn-src-head mailing list