svn commit: r319295 - head/usr.bin/mkimg/tests

Simon J. Gerraty sjg at juniper.net
Thu Jun 1 16:59:16 UTC 2017


Ngie Cooper (yaneurabeya) <yaneurabeya at gmail.com> wrote:
> > These should not be stored uuencoded.  It serves no purpose other
> > than bloating the repo and causing spammy commit mails like this one
> > where we got a huge tail of garbage output.

The tests appear to contain generated filesystem images.
eg. img-1x1-512-mbr.vmdk.gz.uu

Is storing img-1x1-512-mbr.vmdk.gz any more palatable?

One option would be to store a sha256 hash of the result.
If the image generated by the test hashes to the correct value - you
pass.

Of course if the test fails, you are completely in the dark as to
how/why.

With the current arrangment, marcel at least has something he can
examine to see where the output generation went wrong.


More information about the svn-src-head mailing list