svn commit: r320701 - in head: bin sbin usr.bin usr.sbin

Ngie Cooper yaneurabeya at gmail.com
Thu Jul 6 17:34:28 UTC 2017


> On Jul 6, 2017, at 03:31, John Baldwin <jhb at FreeBSD.org> wrote:
> 
>> On 7/6/17 12:15 AM, Ngie Cooper wrote:
>> Author: ngie
>> Date: Thu Jul  6 04:15:30 2017
>> New Revision: 320701
>> URL: https://svnweb.freebsd.org/changeset/base/320701
>> 
>> Log:
>>  Remove SUBDIR ordering/uniquifying in *bin/Makefile
>> 
>>  After the addition of SUBDIR.yes, uniquifying/ordering the SUBDIRs doesn't
>>  make a whole lot of sense, and it's in effect a half measure.
>> 
>>  Ordering SUBDIR (after adding SUBDIR.yes to it) in bsd.subdir.mk is a
>>  separate change that warrants more discussion/testing, because while
>>  the SUBDIR_PARALLEL work largely fixed dependency ordering for SUBDIRs,
>>  there might be downstream FreeBSD consumers that rely on the SUBDIR
>>  ordering.
> 
> FWIW, I (as a human) am used to sorted build output when watching the
> output of 'buildworld' to gauge how far it has completed.  This was a
> feature that SVN broke (CVS would walk directories in sorted order so
> you could do the same sort of guessing for 'cvs up' but you can't for
> 'svn up').  It's not a hard dependency, per se, but it would be nice to
> preserve this feature if possible.  I had noticed that it had become
> less correct "recently".

    I have another change I'm going to propose soon which sorts SUBDIR output (as a whole) again, as an opt-in feature in bsd.subdir.mk.
Cheers,
-Ngie


More information about the svn-src-head mailing list