svn commit: r320705 - head/sys/dev/qlxgbe

David C Somayajulu davidcs at FreeBSD.org
Thu Jul 6 05:16:07 UTC 2017


Author: davidcs
Date: Thu Jul  6 05:16:06 2017
New Revision: 320705
URL: https://svnweb.freebsd.org/changeset/base/320705

Log:
  Release mtx hw_lock before calling pause() in qla_stop() and
  qla_error_recovery()
  
  MFC after: 5 days

Modified:
  head/sys/dev/qlxgbe/ql_os.c

Modified: head/sys/dev/qlxgbe/ql_os.c
==============================================================================
--- head/sys/dev/qlxgbe/ql_os.c	Thu Jul  6 04:56:23 2017	(r320704)
+++ head/sys/dev/qlxgbe/ql_os.c	Thu Jul  6 05:16:06 2017	(r320705)
@@ -1519,8 +1519,11 @@ qla_stop(qla_host_t *ha)
 
 	ha->flags.qla_watchdog_pause = 1;
 
-	while (!ha->qla_watchdog_paused)
+	while (!ha->qla_watchdog_paused) {
+		QLA_UNLOCK(ha);
 		qla_mdelay(__func__, 1);
+		QLA_LOCK(ha);
+	}
 
 	ha->flags.qla_interface_up = 0;
 
@@ -1915,7 +1918,10 @@ qla_error_recovery(void *context, int pending)
 	if (ha->flags.qla_interface_up) {
 
 		ha->hw.imd_compl = 1;
+
+		QLA_UNLOCK(ha);
 		qla_mdelay(__func__, 300);
+		QLA_LOCK(ha);
 
 	        ifp->if_drv_flags &= ~(IFF_DRV_OACTIVE | IFF_DRV_RUNNING);
 


More information about the svn-src-head mailing list