svn commit: r320625 - head/sys/dev/ena

Zbigniew Bodek zbb at FreeBSD.org
Mon Jul 3 23:59:12 UTC 2017


Author: zbb
Date: Mon Jul  3 23:59:11 2017
New Revision: 320625
URL: https://svnweb.freebsd.org/changeset/base/320625

Log:
  Add missing lock upon initialization of the interface
  
  Lack of this lock was causing crash if down was called in
  parallel with the initialization routine.
  
  Submitted by:   Michal Krawczyk <mk at semihalf.com>
  Obtained from:  Semihalf
  Sponsored by:   Amazon.com Inc.

Modified:
  head/sys/dev/ena/ena.c

Modified: head/sys/dev/ena/ena.c
==============================================================================
--- head/sys/dev/ena/ena.c	Mon Jul  3 23:54:39 2017	(r320624)
+++ head/sys/dev/ena/ena.c	Mon Jul  3 23:59:11 2017	(r320625)
@@ -2276,8 +2276,11 @@ ena_init(void *arg)
 {
 	struct ena_adapter *adapter = (struct ena_adapter *)arg;
 
-	if (adapter->up == false)
+	if (adapter->up == false) {
+		sx_xlock(&adapter->ioctl_sx);
 		ena_up(adapter);
+		sx_unlock(&adapter->ioctl_sx);
+	}
 
 	return;
 }


More information about the svn-src-head mailing list