svn commit: r312687 - in head/sys: net sys

Dexuan Cui decui at microsoft.com
Tue Jan 24 22:20:56 UTC 2017


> From: Gleb Smirnoff [mailto:glebius at FreeBSD.org]
>   Dexuan,
> 
> On Tue, Jan 24, 2017 at 09:19:47AM +0000, Dexuan Cui wrote:
> D> --- head/sys/sys/eventhandler.h	Tue Jan 24 09:15:36 2017
> 	(r312686)
> D> +++ head/sys/sys/eventhandler.h	Tue Jan 24 09:19:46 2017
> 	(r312687)
> D> @@ -284,4 +284,11 @@ typedef void (*swapoff_fn)(void *, struc
> D>  EVENTHANDLER_DECLARE(swapon, swapon_fn);
> D>  EVENTHANDLER_DECLARE(swapoff, swapoff_fn);
> D>
> D> +/* ifup/ifdown events */
> D> +#define IFNET_EVENT_UP		0
> D> +#define IFNET_EVENT_DOWN	1
> D> +struct ifnet;
> D> +typedef void (*ifnet_event_fn)(void *, struct ifnet *ifp, int event);
> D> +EVENTHANDLER_DECLARE(ifnet_event, ifnet_event_fn);
> D> +
> D>  #endif /* _SYS_EVENTHANDLER_H_ */
> 
> The network stuff shall not be added to sys/eventhandler.h.
> 
> All these declarations should go to net/if_var.h. There is already
> a block of event(9) defines there. Please move it there.
> 
> --
> Totus tuus, Glebius.

Hi Gleb,
Sorry, I didn't realize this... I'll move it as you suggested.

Thank you for the reminder!

-- Dexuan


More information about the svn-src-head mailing list