svn commit: r312331 - head/contrib/bsnmp/snmpd

[Ngie Cooper (yaneurabeya)]

> On Jan 16, 2017, at 19:52, Gleb Smirnoff <glebius at FreeBSD.org> wrote:
> 
> Author: glebius
> Date: Tue Jan 17 03:52:57 2017
> New Revision: 312331
> URL: https://svnweb.freebsd.org/changeset/base/312331
> 
> Log:
>  Fix regression from r310655, which broke operation of bsnmpd if it is bound
>  to a non-wildcard address.  As documented in ip(4), doing sendmsg(2) with
>  IP_SENDSRCADDR on a socket that is bound to non-wildcard address is
>  completely different to using this control message on a wildcard one.
> 
>  A fix is to add a bool to mark whether we did setsockopt(IP_RECVDSTADDR)
>  on the socket, and use IP_SENDSRCADDR control message only if we did.
> 
>  While here, garbage collect absolutely useless udp_recv() function that
>  establishes some structures on stack to never use them later.

	I wasn’t aware of that — thank you for fixing my mistake (and I’ll add you to the next set of CRs here).
	udp_recv(..) was meant to provide a layer for doing the necessary bits for IPv6.. I guess I’ll have to adjust (and hope that the team doing it internally “gets it right”).
Cheers,
-Ngie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20170116/a99eccaf/attachment.sig>