svn commit: r311585 - in head: crypto/openssh secure/usr.sbin/sshd

Ngie Cooper (yaneurabeya) yaneurabeya at gmail.com
Tue Jan 10 07:58:58 UTC 2017


> On Jan 9, 2017, at 11:56 PM, Xin Li <delphij at delphij.net> wrote:
> 
> 
> On 1/7/17 00:08, Ngie Cooper wrote:
>> Author: ngie
>> Date: Sat Jan  7 08:08:35 2017
>> New Revision: 311585
>> URL: https://svnweb.freebsd.org/changeset/base/311585
>> 
>> Log:
>>  Conditionalize building libwrap support into sshd
>> 
>>  Only build libwrap support into sshd if MK_TCP_WRAPPERS != no
>> 
>>  This will unbreak the build if libwrap has been removed from the system
>> 
>>  MFC after:	2 weeks
>>  PR:		210141
>>  Submitted by:	kpect at protonmail.com
>>  Differential Revision:	D9049
> 
> I didn't see this approved by maintainer, did you ping him?
> 
> [delphij at saturn] /usr/src> grep ssh MAINTAINERS
> openssh         des     Pre-commit review requested.
> 
> (Not that the change itself is bad, though, but it's important to keep
> everyone on the same page).

I waited 3 days for a reply on the review: https://reviews.freebsd.org/D9049 <https://reviews.freebsd.org/D9049> . Admittedly, it was a bit short of a timeout.
-Ngie


More information about the svn-src-head mailing list