svn commit: r313821 - in head/sys: dev/cxgb/ulp/iw_cxgb fs/nfsserver kern netinet netinet/libalias netpfil/ipfw

Eric van Gyzen vangyzen at FreeBSD.org
Fri Feb 17 16:51:53 UTC 2017


On 02/16/2017 22:17, Gleb Smirnoff wrote:
>   Eric,
>
>   heh, things are worse. Multiple places you changes are CTR()
> macros. Neither inet_ntoa() nor inet_ntoa_r() will work with
> them. :(
>
> Basicly non-constant strings can not be logged with KTR. All
> the lines you touched should log actual binary value of the
> IPv4 address.

*facepalm*  It's even worse, because I /knew/ about this, but I failed to think 
of it while making this change.  Oh well.

> I am not asking you to do this work! :) But I couldn't leave
> that without a comment.

:)  Thanks for mentioning it.

Eric


More information about the svn-src-head mailing list