svn commit: r313675 - in head/sys: netinet netinet6

[Cy Schubert]

In message <53D3A92C-6C64-4C0C-A5E6-B659BFA139BF at neville-neil.com>, "George 
Nev
ille-Neil" writes:
> This is an OpenPGP/MIME signed message (RFC 3156 and 4880).
> 
> --=_MailMate_399D2B93-4FB8-4736-9FAB-586EA5CE5549_=
> Content-Type: text/plain; charset=utf-8; markup=markdown
> Content-Transfer-Encoding: quoted-printable
> 
> 
> 
> On 12 Feb 2017, at 6:10, Glen Barber wrote:
> 
> > On Sun, Feb 12, 2017 at 06:56:33AM +0000, Ermal Lu=C3=A7i wrote:
> >> Author: eri
> >> Date: Sun Feb 12 06:56:33 2017
> >> New Revision: 313675
> >> URL: https://svnweb.freebsd.org/changeset/base/313675
> >>
> >> Log:
> >>   Committed without approval from mentor.
> >>
> >>   Reported by:	gnn
> >>
> >
> > What exactly does this mean?
> >
> 
> Ermal took the Acceptance on reviews.freebsd.org by Adrian as an implicit=
>  "go ahead" to commit to the tree.  The issue is that he's still under me=
> ntorship, by me, and had not gotten an approval or had an Approved by: li=
> ne.  I asked him to revert the change himself.
> 
> We're working out a few more issues in the review now.

I didn't read this when I hit send on my email. Hopefully nobody takes 
offense. I was upset and still am.

I still think that the revision numbers of any backout should have been 
documented in the commit log.

Something we could do, as is expected by re@ for commits during a freeze, 
is metees also let their mentors know of what the contents of commit log 
messages will be. I think commit log messages discussing the what, why and 
rationale are as important as the code itself.


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.