svn commit: r313564 - head/sys/kern

Ngie Cooper (yaneurabeya) yaneurabeya at gmail.com
Fri Feb 10 20:19:38 UTC 2017


> On Feb 10, 2017, at 11:38, John Baldwin <jhb at freebsd.org> wrote:
> 
> On Friday, February 10, 2017 07:25:52 PM John Baldwin wrote:
>> Author: jhb
>> Date: Fri Feb 10 19:25:52 2017
>> New Revision: 313564
>> URL: https://svnweb.freebsd.org/changeset/base/313564
>> 
>> Log:
>>  Drop the "created from" line from files generated by makesyscalls.sh.
>> 
>>  This information is less useful when the generated files are included in
>>  source control along with the source.  If needed it can be reconstructed
>>  from the $FreeBSD$ tag in the generated file.  Removing this information
>>  from the generated output permits committing the generated files along
>>  with the change to the system call master list without having inconsistent
>>  metadata in the generated files.
> 
> There is a tradeoff of course.  Having the generated files mixed in the
> commits does make the diff more noisy, and it can be more of a pain in reviews.
> One can still just not include the generated files when posting reviews (we
> already have to do that because you have to generate the files to do testing).
> 
> However, I do think that at least for MFCs we should include the generated
> files in the merge so that on stable branches we don't have known-broken
> commits once this change is merged back to stable branches.

Uhh…. $FreeBSD$ isn’t being expanded in some of these files…

$ svn pg svn:keywords sys/sys/syscall.mk
FreeBSD=%H
$ grep '$FreeBSD' sys/sys/syscall.mk
# $FreeBSD$

-Ngie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20170210/394b34e0/attachment.sig>


More information about the svn-src-head mailing list