svn commit: r327140 - head/sbin/ipfw

[Cy Schubert]

In message <f052b0f4-92e4-07c7-fec7-ada07fc23f04 at yandex.ru>, "Andrey V. 
Elsukov
" writes:
> This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
> --hploe8mi8b5CeIbHnELgS0brwST9uiIfp
> Content-Type: multipart/mixed; boundary="Ua6VdxS4jpKDm90X0cEvNMeMts7m7TLRO";
>  protected-headers="v1"
> From: "Andrey V. Elsukov" <bu7cher at yandex.ru>
> To: rgrimes at freebsd.org
> Cc: src-committers at freebsd.org, svn-src-all at freebsd.org,
>  svn-src-head at freebsd.org
> Message-ID: <f052b0f4-92e4-07c7-fec7-ada07fc23f04 at yandex.ru>
> Subject: Re: svn commit: r327140 - head/sbin/ipfw
> References: <201712240711.vBO7BNRG045404 at pdx.rh.CN85.dnsmgr.net>
> In-Reply-To: <201712240711.vBO7BNRG045404 at pdx.rh.CN85.dnsmgr.net>
>
> --Ua6VdxS4jpKDm90X0cEvNMeMts7m7TLRO
> Content-Type: text/plain; charset=utf-8
> Content-Language: en-US
> Content-Transfer-Encoding: quoted-printable
>
> On 24.12.2017 10:11, Rodney W. Grimes wrote:
> >> -	uint32_t masks[2];
> >> -	int i;
> >> -	uint8_t cmd, rulenum;
> >>  	ipfw_range_tlv rt;
> >>  	char *msg;
> >>  	size_t size;
> >> +	uint32_t masks[2];
> >> +	int i;
> >=20
> > Why do these 2 lines show up as null changes in the diff????
> > I can not see any change, not even white space.
>
> They are sorted by size according to style(9).

When I was still a grasshopper my sensei taught me not to batch commits. 
Looking back, this was wise advice as it is easier for those reading the 
logs to follow each intended change. The two commits should have been: 1) 
fix rule number truncation... and 2) sort size according to style(9).


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.