svn commit: r326991 - in head/sys/fs: nfs nfsclient

John Baldwin jhb at freebsd.org
Thu Dec 21 00:20:03 UTC 2017


On Wednesday, December 20, 2017 01:07:22 PM Ian Lepore wrote:
> On Tue, 2017-12-19 at 19:18 +0000, John Baldwin wrote:
> > Author: jhb
> > Date: Tue Dec 19 19:18:48 2017
> > New Revision: 326991
> > URL: https://svnweb.freebsd.org/changeset/base/326991
> > 
> > Log:
> >   Update NFS to handle larger link counts post ino64.
> > 
> [...]
> > Modified: head/sys/fs/nfsclient/nfs_clvnops.c
> > ==============================================================================
> > --- head/sys/fs/nfsclient/nfs_clvnops.c	Tue Dec 19 19:14:01 2017	(r326990)
> > +++ head/sys/fs/nfsclient/nfs_clvnops.c	Tue Dec 19 19:18:48 2017	(r326991)
> > @@ -3450,7 +3450,7 @@ nfs_pathconf(struct vop_pathconf_args *ap)
> >  		 * For NFSv2 (or NFSv3 when not one of the above 4 a_names),
> >  		 * just fake them.
> >  		 */
> > -		pc.pc_linkmax = LINK_MAX;
> > +		pc.pc_linkmax = NFS_LINK_MAX;
> >  		pc.pc_namemax = NFS_MAXNAMLEN;
> >  		pc.pc_notrunc = 1;
> >  		pc.pc_chownrestricted = 1;
> > @@ -3460,7 +3460,7 @@ nfs_pathconf(struct vop_pathconf_args *ap)
> >  	}
> >  	switch (ap->a_name) {
> >  	case _PC_LINK_MAX:
> > -		*ap->a_retval = pc.pc_linkmax;
> > +		*ap->a_retval = MIN(LONG_MAX, pc.pc_linkmax);
> 
> I just noticed a build error on powerpc LINT and LINT64 kernels on this
> line:
> 
> /b/staging/freebsd/head/src/sys/fs/nfsclient/nfs_clvnops.c:3464:
> warning: comparison is always false due to limited range of data type

Ugh, ok.  I'll do a full tinderbox and clean up any fallout.  I had done one
on an earlier version, but not the latest. :-/  Thanks.

-- 
John Baldwin


More information about the svn-src-head mailing list