svn commit: r321920 - head/sys/sys

Hans Petter Selasky hps at selasky.org
Wed Aug 2 11:14:02 UTC 2017


On 08/02/17 13:06, Konstantin Belousov wrote:
> So linuxkpi was broken before this commit as well, as I noted in my
> other reply ?

Hi,

The LinuxKPI uses minor/major/makedev internally.

y = makedev(z,t)

Then the LinuxKPI assumes z and t can be retrieved through minor and 
major: minor(y) == z and major(y) == t

If "y" is an "int" and it is assigned a 64-bit value, it is obvious that 
this code no longer holds true. Same might be in userspace/ports.

So yes, this change breaks the LinuxKPI, at least some parts of it.

--HPS


More information about the svn-src-head mailing list