svn commit: r316805 - head/sys/dev/ae

Pyun YongHyeon yongari at FreeBSD.org
Fri Apr 14 02:24:03 UTC 2017


Author: yongari
Date: Fri Apr 14 02:24:02 2017
New Revision: 316805
URL: https://svnweb.freebsd.org/changeset/base/316805

Log:
  Fix a potentially forever loop.
  
  Found by:	PVS-Studio

Modified:
  head/sys/dev/ae/if_ae.c

Modified: head/sys/dev/ae/if_ae.c
==============================================================================
--- head/sys/dev/ae/if_ae.c	Fri Apr 14 01:56:15 2017	(r316804)
+++ head/sys/dev/ae/if_ae.c	Fri Apr 14 02:24:02 2017	(r316805)
@@ -1696,7 +1696,7 @@ ae_stop_txmac(ae_softc_t *sc)
 	/*
 	 * Wait for IDLE state.
 	 */
-	for (i = 0; i < AE_IDLE_TIMEOUT; i--) {
+	for (i = 0; i < AE_IDLE_TIMEOUT; i++) {
 		val = AE_READ_4(sc, AE_IDLE_REG);
 		if ((val & (AE_IDLE_TXMAC | AE_IDLE_DMAREAD)) == 0)
 			break;


More information about the svn-src-head mailing list