svn commit: r316477 - head/usr.bin/grep

[Rodney W. Grimes]

> On 04.04.2017 15:24, Kyle Evans wrote:
> > On Tue, Apr 4, 2017 at 7:07 AM, Andrey Chernov <ache at freebsd.org
> > <mailto:ache at freebsd.org>> wrote:
> > 
> >     On 04.04.2017 2:16, Ed Maste wrote:
> >     >                       if (color)
> >     > -                             fprintf(stdout, "\33[m\33[K");
> >     > +                             fprintf(stdout, "\33[00m\33[K");
> > 
> >     Please back that one out. We don't need to handle internally or print
> >     remotely excessive 00.
> >     At least according to
> >     https://en.wikipedia.org/wiki/ANSI_escape_code
> >     <https://en.wikipedia.org/wiki/ANSI_escape_code>
> >     "With no parameters, CSI m is treated as CSI 0 m (reset / normal), which
> >     is typical of most of the ANSI escape sequences."
> > 
> > 
> > Hi ache@,
> > 
> > This specific change was made in the name of explicitly matching colored
> > output of GNU grep for simplification of regression test purposes,
> > rather than for good form. Is it still unacceptable to do so?
> 
> IMHO everyday usage by everyone weights much more than occasional
> regression tests run which can be fixed instead of this place. F.e. we
> already do a lot of local fixes in the NetBSD regression tests instead
> of pretending to mimic NetBSD in 100% in the system itself.


Also it might be worth making NetBSD aware of the bad output, and fix
it there, and the regression test, and everyone well be better off.

-- 
Rod Grimes                                                 rgrimes at freebsd.org