svn commit: r305659 - head/sys/fs/nullfs
Mateusz Guzik
mjg at FreeBSD.org
Fri Sep 9 10:40:56 UTC 2016
Author: mjg
Date: Fri Sep 9 10:40:55 2016
New Revision: 305659
URL: https://svnweb.freebsd.org/changeset/base/305659
Log:
nullfs: plug vnode ref leak in null_vptocnp
The lower vnode is already referenced and nodeget is supposed to consume
the reference. Thus the extra vref call was causing a leak.
Reported by: pho
Reviewed by: kib
MFC after: 1 week
Modified:
head/sys/fs/nullfs/null_vnops.c
Modified: head/sys/fs/nullfs/null_vnops.c
==============================================================================
--- head/sys/fs/nullfs/null_vnops.c Fri Sep 9 10:04:38 2016 (r305658)
+++ head/sys/fs/nullfs/null_vnops.c Fri Sep 9 10:40:55 2016 (r305659)
@@ -893,7 +893,6 @@ null_vptocnp(struct vop_vptocnp_args *ap
vn_lock(vp, locked | LK_RETRY);
return (ENOENT);
}
- vref(ldvp);
error = null_nodeget(vp->v_mount, ldvp, dvp);
if (error == 0) {
#ifdef DIAGNOSTIC
More information about the svn-src-head
mailing list