svn commit: r308696 - in head: share/man/man4 sys/boot/forth sys/conf sys/dev/bnxt sys/modules sys/modules/bnxt

Stephen Hurd shurd at sasktel.net
Tue Nov 22 20:42:12 UTC 2016


Conrad Meyer wrote:
> Hi Stephen,
>
> Coverity reports a missing 'break;' (or explicit /* FALLTHROUGH */) in
> if_bnxt.c:1915.  (The HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASEKR cases
> flow into the HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASELR case.)  CID is
> 1366223.
>
> If the fall-through is intentional, please add the comment.  If it
> isn't, I guess it needs a break statement.
>
> Thanks,
> Conrad

Yes, that needs the break.  I'll get that in today.


More information about the svn-src-head mailing list