svn commit: r308691 - in head/sys: cddl/compat/opensolaris/sys cddl/contrib/opensolaris/uts/common/fs/zfs fs/tmpfs kern vm

[Mark Millard]

Alan Cox alc at rice.edu wrote on Wed Nov 16 17:54:03 UTC 2016 :

> This change amounted to dead code removal, so I'm not sure how it could
> have an effect.  There were only a couple places where the changes were
> other than mechanical in nature.  Also, that the number of cores matters
> is no less puzzling.

But bugzilla 214629 reports a fix that is not checked in yet:

Andriy Gapon in Comment 1 notes for /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c around line 430 (as listed in the description):

> Now that 'else if (pp == NULL)' block has been removed (and we no longer fabricate a cached page), the code should look like:
> ...
> else if (pp != NULL) {
>   ASSERT(!pp->valid);
>   pp = NULL;
> }


Alan Cox then agrees (Comment 2) --and Shawn Webb reports trying the change fixed the issue for him (Comment 3).

So once the fix is checked in and put to use this issue will likely go away.


===
Mark Millard
markmi at dsl-only.net