svn commit: r308664 - in head: contrib/hyperv/tools etc/devd etc/mtree include share/man/man4 sys/conf sys/dev/hyperv/utilities sys/modules/hyperv/utilities usr.sbin/hyperv usr.sbin/hyperv/tools us...

[Dimitry Andric]

On 17 Nov 2016, at 01:31, Ngie Cooper <yaneurabeya at gmail.com> wrote:
> 
> On Wed, Nov 16, 2016 at 2:14 PM, Mark Johnston <markj at freebsd.org> wrote:
> ...
>> This appears to install hv_kvp_daemon and hv_vss_daemon to / instead of
>> /usr/sbin, and breaks the -DNO_ROOT build. I think a Makefile.inc is
>> needed in usr.sbin/hyperv/tools in order to preserve BINDIR from
>> usr.sbin/Makefile.inc. I fixed the problem in my tree with the diff
>> below, but am not sure if this is the right way to do it. For some
>> reason, doing this resulted in unused var warnings compiling
>> hv_vss_daemon.c.
> 
>    The -Wunused warnings you're seeing are because you're now it's
> setting WARNS by .include'ing usr.bin/Makefile.inc ; it used to be set
> (I verified that), but then got unset between a few weeks ago and now
> on the directory:
> 
> $ make -V.CURDIR -VWARNS
> /usr/src/usr.sbin/hyperv/tools
> 
> $
> 
> Cheers,
> -Ngie
> 
> PS -Wno-uninitialized is only set for gcc...? Really...???

Yes, because base gcc has produced many false positives with its
-Wuninitialized warnings.  In fact, I would suggest that is globally
turned off for any gcc version before 4.7.

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20161117/790578b3/attachment.sig>